Re: pgsql: Fix minor problems with non-exclusive backup cleanup.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix minor problems with non-exclusive backup cleanup.
Date: 2020-08-06 18:19:46
Message-ID: 2636501.1596737986@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> Fix minor problems with non-exclusive backup cleanup.

Seems like there's an extra space in this error message in
do_pg_abort_backup:

+ if (emit_warning)
+ ereport(WARNING,
+ (errmsg("aborting backup due to backend exiting before pg_stop_back up was called")));

Also, while I'm bugging you: it wasn't quite clear from the thread
whether this is alone sufficient to fix the user-visible issue
reported by Bharath Rupireddy, or whether we still need to change
the JIT logic as well to do that.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2020-08-06 18:20:55 pgsql: Register llvm_shutdown using on_proc_exit, not before_shmem_exit
Previous Message Robert Haas 2020-08-06 18:11:15 pgsql: Fix minor problems with non-exclusive backup cleanup.