| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tristan Partin <tristan(at)neon(dot)tech> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)postgresql(dot)org, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Subject: | Re: psql not responding to SIGINT upon db reconnection |
| Date: | 2024-04-03 19:49:09 |
| Message-ID: | CA+Tgmoa6K8ZWr=FjAA_RDDPHH-pibt_4+_fH0fSna5woWZfLXQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 3, 2024 at 11:17 AM Tristan Partin <tristan(at)neon(dot)tech> wrote:
> I think patch 2 makes it worse. The value in -Wswitch is that when new
> enum variants are added, the developer knows the locations to update.
> Adding a default case makes -Wswitch pointless.
>
> Patch 1 is still good. The comment change in patch 2 is good too!
It seems to me that 0001 should either remove the pg_unreachable()
call or change the break to a return, but not both. The commit message
tries to justify doing both by saying that the pg_unreachable() call
doesn't have much value, but there's not much value in omitting
pg_unreachable() from unreachable places, either, so I'm not
convinced.
I agree with Tristan's analysis of 0002.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2024-04-03 19:53:37 | Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan |
| Previous Message | Andrew Dunstan | 2024-04-03 19:48:31 | Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~? |