| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Badrul Chowdhury <bachow(at)microsoft(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Satyanarayana Narlapuram <Satyanarayana(dot)Narlapuram(at)microsoft(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility) |
| Date: | 2017-11-21 19:47:57 |
| Message-ID: | CA+Tgmoa09XhJBG+EJ8q+83_rwQtOin35GJpUwXU5T320Mkug_w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 19, 2017 at 7:49 PM, Badrul Chowdhury <bachow(at)microsoft(dot)com> wrote:
>>> I spent a little more time looking at this patch today. I think that the patch
>>> should actually send NegotiateProtocolVersion when *either* the requested
>>> version is differs from the latest one we support *or* an unsupported protocol
>>> option is present. Otherwise, you only find out about unsupported protocol
>>> options if you also request a newer minor version, which isn't good, because it
>>> makes it hard to add new protocol options *without* bumping the protocol
>>> version.
>
> It makes sense from a maintainability point of view.
>
>>> Here's an updated version with that change and a proposed commit message.
>
> I have tested the new patch and it works great. The comments look good as well.
Committed and back-patched to all supported branches.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-11-21 20:14:18 | Re: [HACKERS] Parallel Append implementation |
| Previous Message | Andrew Dunstan | 2017-11-21 18:44:36 | Re: [HACKERS] SQL procedures |