Re: code contributions for 2024, WIP version

On Thu, Dec 5, 2024 at 7:46 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> No corrections here -- I noticed nothing wrong with the commits I am
> involved with, in a quick read. I did notice that for patches with
> multiple authors, only the first one is listed. For instance,
> 53c2a97a926's author ("Improve performance of subsystems on top of
> SLRU") is listed as Andrey Borodin, leaving Dilip Kumar out. I realize
> that addressing this would complicate the schema and queries, but maybe
> it's worth thinking about for next time. We have plenty of patches with
> multiple authors, after all.

I agree, but I don't know how to apportion the work between the
authors. I think dividing credit equally between two or three authors
would often be very unfair to the first author. If we want to annotate
commit messages in a way that allows me to apportion credit more
fairly, I'm totally game to do that, but otherwise I think that giving
the credit to the first author is probably more fair on average.

> Hmm, maybe
> UPDATE commits2024 SET xlines = 0 WHERE commitid in
> ('43ce181059d', '4632e5cf4bc', '6377e12a5a5', 'ff9f72c68f6',
> '21ef4d4d897', '592a2283721');

Thanks.

> How did you come up with the 'lines' number for each commit anyway?
> Judging by 592a2283721 it's not just the number of lines added, since
> that commit added 3 lines and you have lines=2.

git log --before=${YEAR}-12-31 --after=${YEAR}-01-01 --shortstat -w -M

--
Robert Haas
EDB: http://www.enterprisedb.com