| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_amcheck contrib application |
| Date: | 2021-03-12 19:31:36 |
| Message-ID: | CA+TgmoZUJ4j31CbnUz-DpBBq_DVoaYcuG5XB7hP71+uQ=js_KQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 12, 2021 at 1:35 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Fri, Mar 12, 2021 at 10:32 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > Thank you both, Mark and Robert. This is excellent work!
Thanks.
> FYI I see these compiler warnings just now:
>
> pg_amcheck.c:1653:4: warning: ISO C90 forbids mixed declarations and
> code [-Wdeclaration-after-statement]
> 1653 | DatabaseInfo *dat = (DatabaseInfo *)
> pg_malloc0(sizeof(DatabaseInfo));
> | ^~~~~~~~~~~~
> pg_amcheck.c: In function ‘compile_relation_list_one_db’:
> pg_amcheck.c:2060:9: warning: variable ‘is_btree’ set but not used
> [-Wunused-but-set-variable]
> 2060 | bool is_btree = false;
> | ^~~~~~~~
>
> Looks like this 'is_btree' variable should be PG_USED_FOR_ASSERTS_ONLY.
I'll commit something shortly to address these.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-12 20:08:20 | Re: [patch] [doc] Minor variable related cleanup and rewording of plpgsql docs |
| Previous Message | Robert Haas | 2021-03-12 19:24:01 | Re: pg_amcheck contrib application |