MV patch broke users of ExplainOneQuery_hook

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: MV patch broke users of ExplainOneQuery_hook
Date: 2013-04-09 14:00:05
Message-ID: CA+TgmoZTjoBh40gZd8CoyWbwfUhNtLXF+nA0nG6P8FNhcThfGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The materialized views patch adjusted ExplainOneQuery to take an
additional DestReceiver argument, but failed to add a matching
argument to the definition of ExplainOneQuery_hook. This makes the
hook unusable. The idea of this hook is that your hook function will
do something before and/or after calling pg_plan_query and
ExplainOnePlan. But this no longer works, because ExplainOnePlan
needs the DestReceiver, which hasn't been exposed to the hook. :-(

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2013-04-09 14:11:19 Re: MV patch broke users of ExplainOneQuery_hook
Previous Message Rodrigo Barboza 2013-04-09 12:48:32 Re: Unrecognized type error (postgres 9.1.4)