Re: MV patch broke users of ExplainOneQuery_hook

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: MV patch broke users of ExplainOneQuery_hook
Date: 2013-04-09 14:11:19
Message-ID: 1365516679.28116.YahooMailNeo@web162903.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> The materialized views patch adjusted ExplainOneQuery to take an
> additional DestReceiver argument, but failed to add a matching
> argument to the definition of ExplainOneQuery_hook.  This makes the
> hook unusable.  The idea of this hook is that your hook function will
> do something before and/or after calling pg_plan_query and
> ExplainOnePlan.  But this no longer works, because ExplainOnePlan
> needs the DestReceiver, which hasn't been exposed to the hook.  :-(

Feel free to go ahead and fix this if you like; otherwise I'll look
at it later today.

--
Kevin Grittner
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-04-09 14:25:35 Re: MV patch broke users of ExplainOneQuery_hook
Previous Message Robert Haas 2013-04-09 14:00:05 MV patch broke users of ExplainOneQuery_hook