Re: logical replication launcher crash on buildfarm

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: logical replication launcher crash on buildfarm
Date: 2017-04-16 05:35:46
Message-ID: CA+TgmoZRtrxLuGMQNrPqpn6ks9EFURp1mWcf3d8qDQFpOBwdsQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Apr 15, 2017 at 12:01 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Maybe we need to rethink the division of labor between parallel.c
> and execParallel.c, but that would depend on somebody explaining
> what the difference is in the first place.

parallel.c handles general concerns related to any sort of
parallelism, particularly those related to transaction management,
hence it's in src/backend/access/transam. execParallel.c handles
concerns that are specific to the executor, hence it's in
src/backend/executor. The header comment for execParallel.c is fairly
informative on this point; now that I look at it, parallel.c has only
a stub comment, which really ought to be expanded. Note that while
parallel *query* uses both, a parallel utility command will likely use
only the facilities in parallel.c, so the distinction is not academic.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2017-04-16 05:36:24 Re: SCRAM authentication, take three
Previous Message Noah Misch 2017-04-16 04:25:31 Re: Re: extended stats not friendly towards ANALYZE with subset of columns