Re: Incorrect overflow check condition for WAL segment size

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Markus Nullmeier <dq124(at)uni-heidelberg(dot)de>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Subject: Re: Incorrect overflow check condition for WAL segment size
Date: 2016-11-09 17:58:54
Message-ID: CA+TgmoZMuRz=dT91AZ2AxA=JoqHNN8QPEPrJA52E7Hj43Tqh3g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 9, 2016 at 12:54 PM, Markus Nullmeier
<dq124(at)uni-heidelberg(dot)de> wrote:
> On 11/08/16 18:12, Robert Haas wrote:
>> On Tue, Nov 8, 2016 at 1:01 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> On Tue, Nov 8, 2016 at 2:33 PM, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> wrote:
>>>> I've attached a patch to fix this.
>>> Good catch. Interesting copy-pasto from 88e9823.
>> Committed.
>
> Hmm, somehow this fix (60379f66c8 for master) does not seem to appear
> in the 9.5 and 9.6 branches, yet the latter both include commit 88e9823.

It didn't seem important to back-patch it, so I didn't. It also
occurred to me that there was a small chance of breaking the build for
somebody who is skating by today, which would annoy that person
without being likely to benefit anyone else.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-11-09 18:08:23 Re: PassDownLimitBound for ForeignScan/CustomScan [take-2]
Previous Message Robert Haas 2016-11-09 17:55:51 Re: Is user_catalog_table sensible for matviews?