Re: pg_verifybackup: TAR format backup verification

On Fri, Sep 27, 2024 at 2:07 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> Thank you, Robert. The code changes look much better now.

Cool.

> A few minor comments:
>
> + each tablespace, named after the tablespace's OID. If the backup
> + is compressed, the relevant compression extension is added to the
> + end of each file name.
>
> I am a bit unsure about the last line, especially the use of the word
> "added." I feel like it's implying that we're adding something, which
> isn't true.

If you add .gz to the end of 16904.tar, you get 16904.tar.gz. This
seems like correct English to me.

> Typo: futher

OK, thanks.

> The addition of simple_ptr_list_destroy will be part of a separate
> commit, correct?

To me, it doesn't seem worth splitting that out into a separate commit.

--
Robert Haas
EDB: http://www.enterprisedb.com