| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Why does load_external_function() return PGFunction? |
| Date: | 2018-05-13 13:01:10 |
| Message-ID: | CA+TgmoZ5TxUP+LuMA60N8t=x6tO0+7m7W82n8upZ1bguaBm4YA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 10, 2018 at 4:45 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Possible. But IIRC the parameter-unknown form isn't valid C++ and Peter
> Eisentraut has done a good chunk of work to make it possible to compile
> postgres as that. We shouldn't make his job harder.
Fair point.
> IMO the important
> part isn't that the parameters fit exactly - we'll have to cast for the
> return type anyway - but that it's declared as a pointer-to-function for
> the hyptothetical supported platform that has different pointers to
> functions than to other objects.
Probably the more relevant concern is what's going to compile
warning-free on all supported compilers. I think it's unlikely that
such a hypothetical supported platform actually exists, although maybe
I'm wrong.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-05-13 15:05:50 | Re: Why does load_external_function() return PGFunction? |
| Previous Message | Robert Haas | 2018-05-13 12:59:45 | Re: Indexes on partitioned tables and foreign partitions |