Re: [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Cc: PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt
Date: 2011-07-09 02:15:55
Message-ID: CA+TgmoZ0rry=Q+r9pxmLZGj9a637Hd+JCMyXJAC+vwVXwox9ig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 8, 2011 at 9:06 AM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
> I definitely agree with this idea. It will enables to eliminate ugly switch
> statements for error-messaging reasons.

All right, so please submit a patch that introduces that concept
first, and then resubmit this patch rebased over those changes.

In view of the time remaining in this CommitFest, I am going to mark
this Returned with Feedback for now. The next CommitFest starts
September 15th, but I'll try to review it sooner as time permits.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-07-09 02:27:12 Re: dropping table in testcase alter_table.sql
Previous Message Robert Haas 2011-07-09 01:42:28 Re: [v9.2] Fix leaky-view problem, part 2