| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
| Cc: | amul sul <sulamul(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Support Parallel Append plan nodes. |
| Date: | 2017-12-06 13:48:08 |
| Message-ID: | CA+TgmoYkAPOfvE7HahjvcnO_PqFKeVkasCQ5Sd5pC+kgBnSYhA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Dec 6, 2017 at 5:01 AM, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
> This looks good.
>
> In attached revised patch, just added some comments in the changes that you did.
Committed, thanks. It's rather embarrassing that I didn't notice this
problem, because I did compare that logic with the preceding loop. I
concluded it was OK on the theory the previous loop would have already
given up if there were no partial plans. But that's wrong, of course:
the previous loop will not have given up if it grabbed the last plan
in a list of only non-partial plans. Oops.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-12-06 13:59:30 | Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple |
| Previous Message | Robert Haas | 2017-12-06 13:46:22 | pgsql: Fix Parallel Append crash. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-12-06 13:59:30 | Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple |
| Previous Message | Amit Kapila | 2017-12-06 12:09:09 | Re: Usage of epoch in txid_current |