From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, amul sul <sulamul(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Support Parallel Append plan nodes. |
Date: | 2017-12-06 15:29:16 |
Message-ID: | 30198.1512574156@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Dec 6, 2017 at 5:01 AM, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
>> In attached revised patch, just added some comments in the changes that you did.
> Committed, thanks.
While this patch (looks like it) fixes the logic error, it does nothing
for the problem that the committed test cases don't actually exercise
any of this code on most machines -- certainly not whichever one is
producing the code coverage report:
https://coverage.postgresql.org/src/backend/executor/nodeAppend.c.gcov.html
Can we do something with Andres' suggestion of running these test cases
under parallel_leader_participation = off?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2017-12-06 16:21:15 | Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple |
Previous Message | Robert Haas | 2017-12-06 14:11:20 | pgsql: Report failure to start a background worker. |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2017-12-06 15:47:12 | Re: ALTER TABLE ADD COLUMN fast default |
Previous Message | Dang Minh Huong | 2017-12-06 15:23:52 | Re: User defined data types in Logical Replication |