From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Comment on GatherPath.single_copy |
Date: | 2016-08-31 06:56:48 |
Message-ID: | CA+TgmoYgMGBc+GWfdv48Ufqbo30i85Unc4jNiMGw0hr2av+K0w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 30, 2016 at 6:38 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> writes:
>> - bool single_copy; /* path must not be executed >1x */
>> + bool single_copy; /* path must not span on multiple processes */
>
> I agree that the existing comment sucks, but this isn't a lot better
> (and it will probably not look nice after pgindent gets done with it).
> Possibly it's too complicated to jam a reasonable explanation into the
> same-line comment, and what is needed is to expand the sentence about
> it in the comment above the struct.
>
> Robert, could you fix the documentation for that field so it's
> intelligible?
Uh, maybe. The trick, as you've already noted, is finding something
better. Maybe this:
- bool single_copy; /* path must not be executed >1x */
+ bool single_copy; /* don't execute path in multiple processes */
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-08-31 07:00:06 | Re: Aggregate Push Down - Performing aggregation on foreign server |
Previous Message | Michael Paquier | 2016-08-31 06:35:33 | Re: Missing checks when malloc returns NULL... |