| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | "Rady, Doug" <radydoug(at)amazon(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |
| Date: | 2017-11-29 12:58:55 |
| Message-ID: | CA+TgmoYbTX-Q_LngthrHOS1y1wbS8bBD1Vf0ZqXskp7W3cKzmw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 29, 2017 at 3:40 AM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> ever is best. Not sure that "pfds" is the right name. If the two variables
> means the same thing, they should have the same name, although possibly
> different types.
Although I agree with a good bit of what you say here, I don't agree
with that. If the member used by ppoll() (or just poll()) has a
different name than the one used for select(), it's much easier to,
say, grep for everyplace where the field you care about is used. If
you use the same name for different things, that doesn't work.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2017-11-29 13:10:58 | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |
| Previous Message | Michael Paquier | 2017-11-29 12:38:41 | Re: [HACKERS] CUBE seems a bit confused about ORDER BY |