Re: tablespace_map code cleanup

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tablespace_map code cleanup
Date: 2020-05-27 11:57:38
Message-ID: CA+TgmoYZhRBAyya_yXd_7fx4-RyjtE2KvGNMN0LUg737+-9a1g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 13, 2020 at 10:43 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
> About 0002,
>
> + bool sendtblspclinks = true;
>
> The boolean seems to me useless since it is always the inverse of
> opt->sendtblspcmapfile when it is used.

Well, I think it might have some documentation value, to clarify that
whether or not we send tablespace links is the opposite of whether we
send the tablespace map file.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2020-05-27 12:00:55 Re: Make the qual cost on index Filter slightly higher than qual cost on index Cond.
Previous Message Mahendra Singh Thalor 2020-05-27 11:49:04 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions