| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | robertmhaas(at)gmail(dot)com |
| Cc: | amit(dot)kapila16(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: tablespace_map code cleanup |
| Date: | 2020-05-28 00:11:14 |
| Message-ID: | 20200528.091114.1856868282194106428.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 27 May 2020 07:57:38 -0400, Robert Haas <robertmhaas(at)gmail(dot)com> wrote in
> On Wed, May 13, 2020 at 10:43 PM Kyotaro Horiguchi
> <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> > About 0002,
> >
> > + bool sendtblspclinks = true;
> >
> > The boolean seems to me useless since it is always the inverse of
> > opt->sendtblspcmapfile when it is used.
>
> Well, I think it might have some documentation value, to clarify that
> whether or not we send tablespace links is the opposite of whether we
> send the tablespace map file.
That makes sense to me. Thanks!
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-05-28 00:31:27 | Re: Explain Analyze (Rollback off) Suggestion |
| Previous Message | Mark Dilger | 2020-05-27 23:00:03 | Re: New 'pg' consolidated metacommand patch |