| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back |
| Date: | 2022-01-19 01:55:05 |
| Message-ID: | CA+TgmoYRfp8ye=AzmKewwnuzVijBya3aHv4tLgK9+mkAVuMOCg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Jan 18, 2022 at 5:12 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Now that I re-read what you did, I believe you need both of
>
> -fsanitize=alignment -fsanitize-trap=alignment
>
> to enable those traps to happen. That seems to be the case with
> Apple's clang, anyway.
Ah, I guess I copied and pasted the options wrong, or something.
Anyway, I have an idea how to fix this. I didn't realize that we were
going to read from the bbsink's buffer like this, and it's not
properly aligned for that. I'll jigger things around to fix that.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-01-19 02:23:08 | Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back |
| Previous Message | Andres Freund | 2022-01-19 01:49:57 | Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Coleman | 2022-01-19 01:58:01 | Re: Add last commit LSN to pg_last_committed_xact() |
| Previous Message | Andres Freund | 2022-01-19 01:49:57 | Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back |