Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
Date: 2022-01-18 22:12:00
Message-ID: 415517.1642543920@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Unfortunately, I can't reproduce this locally, even with COPT=-Wall
> -Werror -fno-omit-frame-pointer -fsanitize-trap=alignment
> -Wno-deprecated-declarations -DWRITE_READ_PARSE_PLAN_TREES
> -DSTRESS_SORT_INT_MIN -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS.

Now that I re-read what you did, I believe you need both of

-fsanitize=alignment -fsanitize-trap=alignment

to enable those traps to happen. That seems to be the case with
Apple's clang, anyway.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-01-18 22:19:06 Re: pgsql: Test replay of regression tests, attempt II.
Previous Message Tom Lane 2022-01-18 22:06:11 Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-01-18 22:29:25 Re: a misbehavior of partition row movement (?)
Previous Message Tom Lane 2022-01-18 22:06:11 Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back