From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql(at)j-davis(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: new compiler warnings |
Date: | 2011-10-18 19:28:51 |
Message-ID: | CA+TgmoYP7dJbxagfBC3unB-mB9W8Mnb5x1vY32VhP9pyusf6Nw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Oct 18, 2011 at 3:03 PM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>> My dim recollection is that Tom and I and maybe some others did
>> tests on a bunch of platforms at the time we introduced the
>> protocol to make sure it did work this way, since it's crucial to
>> making sure we don't get interleaved log lines.
>
> Testing is good; I like testing. But I've seen people code to
> implementation details in such a way that things worked fine until
> the next release of a product, when the implementation changed. I
> was surprised to see Tom, who is normally such a stickler for doing
> such things correctly, apparently going the other way this time; but
> it turns out that he had noted a guarantee in the API that I'd
> missed. Mystery solved.
>
> Perhaps something in the comments would help people avoid making the
> same mistake I did.
Unfortunately, whether Tom's right or not, we still don't have a
solution to the compiler warning.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-10-18 19:43:44 | Re: new compiler warnings |
Previous Message | Robert Haas | 2011-10-18 19:28:05 | Re: termination of backend waiting for sync rep generates a junk log message |