Re: new compiler warnings

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>,<pgsql(at)j-davis(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: new compiler warnings
Date: 2011-10-18 19:03:47
Message-ID: 4E9D874302000025000421B1@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:

> My dim recollection is that Tom and I and maybe some others did
> tests on a bunch of platforms at the time we introduced the
> protocol to make sure it did work this way, since it's crucial to
> making sure we don't get interleaved log lines.

Testing is good; I like testing. But I've seen people code to
implementation details in such a way that things worked fine until
the next release of a product, when the implementation changed. I
was surprised to see Tom, who is normally such a stickler for doing
such things correctly, apparently going the other way this time; but
it turns out that he had noted a guarantee in the API that I'd
missed. Mystery solved.

Perhaps something in the comments would help people avoid making the
same mistake I did.

-Kevin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-10-18 19:21:49 Re: (patch) regression diffs on collate.linux.utf8 test
Previous Message Kevin Grittner 2011-10-18 18:57:51 Re: new compiler warnings