| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Zhang Zq <zqzhangmail(at)163(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch for xidin |
| Date: | 2015-04-29 21:55:51 |
| Message-ID: | CA+TgmoYJ5Ztj21bKU7SzeSdfn8u7RJGUYYEtfJigvQC5YfAZBw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 17, 2015 at 10:27 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The patch will correct it. I have justly copy some code of 'OID'. Whether we need to extract the common code?
>
> This seems like an awful lot of code to solve a problem that will never
> occur in practice.
It does seem like an awful lot of code. We should be able to come up
with something shorter. But the bug report is legitimate. It's not
too much to ask that data types sanity check their inputs.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-04-29 21:59:41 | Re: [PATCH] libpq: Allow specifying multiple host names to try to connect to |
| Previous Message | Michael Paquier | 2015-04-29 21:55:31 | Re: [COMMITTERS] pgsql: Add transforms feature |