| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Zhang Zq" <zqzhangmail(at)163(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch for xidin |
| Date: | 2015-04-17 14:27:21 |
| Message-ID: | 5031.1429280841@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Zhang Zq" <zqzhangmail(at)163(dot)com> writes:
> The implements of 'xidin' use only strtoul to cast from string to xid. So in some cases, may cause confusion, for example,
> The sql 'select c1 from test where xmin='abc' can be executed. and sometimes will make mistakes, I want to query "select c1 from test where xmin='0x10'" ,but write 'Ox10', '0' to 'O',The result is obviously wrong.
> The patch will correct it. I have justly copy some code of 'OID'. Whether we need to extract the common code?
This seems like an awful lot of code to solve a problem that will never
occur in practice.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2015-04-17 14:33:04 | Buildfarm client version 4.15 released |
| Previous Message | Heikki Linnakangas | 2015-04-17 14:21:58 | Re: Manipulating complex types as non-contiguous structures in-memory |