Re: Sum aggregate calculation for single precsion real

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Sum aggregate calculation for single precsion real
Date: 2017-02-15 12:52:54
Message-ID: CA+TgmoYBfRS5exdRqqW_cotMezV4zuc1NpG1V+R8YSafi_1zbg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 14, 2017 at 11:45 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> You could perhaps make an argument that sum(float4) would have less risk
> of overflow if it accumulated in and returned float8, but frankly that
> seems a bit thin.

I think that's more or less the argument Konstantin is in fact making.
Whether it's a good argument or a thin one is a value judgement.
Personally, I find it somewhere in the middle: I think the way it
works now is reasonable, and I think what he wants would have been
reasonable as well. However, I find it hard to believe it would be
worth changing now on backward compatibility grounds. He doesn't like
the way it works currently, but we have no way of knowing how many
people who are happy with the way it works today would become unhappy
if we changed it. We need a fairly compelling reason to risk breaking
somebody's SQL, and I don't think this rises to that level.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-02-15 12:57:53 Re: Documentation improvements for partitioning
Previous Message Robert Haas 2017-02-15 12:47:59 Re: Parallel Index Scans