| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: pg_upgrade: simplify code layout in a few places |
| Date: | 2018-01-05 19:31:51 |
| Message-ID: | CA+TgmoY-7Zr-oNePrbC1rs_HTGv6Biy8STu5hfGE3_Z_bmgOiA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Jan 5, 2018 at 2:24 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Fri, Jan 5, 2018 at 02:20:59PM -0500, Robert Haas wrote:
>> On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> > pg_upgrade: simplify code layout in a few places
>> >
>> > Backpatch-through: 9.4 (9.3 didn't need improving)
>>
>> Hmm. We don't normally do things like this, because it breaks translatability.
>
> Oh, you mean the 'if()' statement? If so, I will revert that and add a
> comment so I don't do it again in that place.
Yeah.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-01-05 19:32:12 | Re: pgsql: pg_upgrade: simplify code layout in a few places |
| Previous Message | Bruce Momjian | 2018-01-05 19:24:54 | Re: pgsql: pg_upgrade: simplify code layout in a few places |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-01-05 19:32:12 | Re: pgsql: pg_upgrade: simplify code layout in a few places |
| Previous Message | Alexander Korotkov | 2018-01-05 19:31:36 | Re: [HACKERS] Pluggable storage |