| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Israel Barth Rubio <barthisrael(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add -k/--link option to pg_combinebackup |
| Date: | 2025-03-18 17:50:47 |
| Message-ID: | CA+TgmoY-4uRhz_EEKYZrMmg9ZY2vENiarjsSPgDSeSPX-M_zow@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 18, 2025 at 10:31 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > On Mar 18, 2025, at 9:34 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > On Tue, Mar 18, 2025 at 9:27 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> >> Maybe we could have a TAP test module that would run it but only if you
> >> have "code-indent" in your PG_TEST_EXTRA.
> > What is the argument against always testing this?
>
> Just a question if everyone wants to run this. Koel takes about 10s to run the indent test.
Well, IMHO, that's pretty cheap insurance against having to push a
second commit to fix indentation. But I guess one problem is not
everyone may have pgindent installed locally.
But at least I should get it set up here. I tried setting
PG_TEST_EXTRA=code-indent locally and running 'meson test' and I
didn't get a failure -- and 'git grep code-indent' returned nothing.
Any tips?
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2025-03-18 17:54:52 | Re: CRC32C Parallel Computation Optimization on ARM |
| Previous Message | Andres Freund | 2025-03-18 17:50:10 | Re: optimize file transfer in pg_upgrade |