| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Israel Barth Rubio <barthisrael(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add -k/--link option to pg_combinebackup |
| Date: | 2025-03-18 17:55:32 |
| Message-ID: | 110272.1742320532@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Mar 18, 2025 at 10:31 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> Just a question if everyone wants to run this. Koel takes about 10s to run the indent test.
> Well, IMHO, that's pretty cheap insurance against having to push a
> second commit to fix indentation. But I guess one problem is not
> everyone may have pgindent installed locally.
10s added to every check-world run doesn't sound "cheap" to me.
However, both pg_bsd_indent and the typedefs list are in-tree
nowadays, so I don't see any reason that this couldn't be a
totally self-contained check.
> But at least I should get it set up here. I tried setting
> PG_TEST_EXTRA=code-indent locally and running 'meson test' and I
> didn't get a failure -- and 'git grep code-indent' returned nothing.
> Any tips?
Andrew was suggesting a test we could write, not one we
already have.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2025-03-18 18:20:55 | Re: Using read_stream in index vacuum |
| Previous Message | Bruce Momjian | 2025-03-18 17:54:52 | Re: CRC32C Parallel Computation Optimization on ARM |