| From: | Yurii Rashkovskii <yrashk(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] pg_convert improvement |
| Date: | 2023-11-24 14:32:55 |
| Message-ID: | CA+RLCQzAbj6yFd2-PZaMJNjSxQNyZAU_Y+Z2FLKFPbUo5iCf7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Bertrand,
On Fri, Nov 24, 2023 at 6:26 AM Drouvot, Bertrand <
bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> The patch is pretty straightforward, I just have one remark:
>
> + /* if no actual conversion happened, return the original string */
> + /* (we are checking pointers to strings instead of encodings
> because
> + `pg_do_encoding_conversion` above covers more cases than just
> + encoding equality) */
>
> I think this could be done in one single comment and follow the preferred
> style
> for multi-line comment, see [1].
>
Thank you for your feedback. I've attached a revised patch.
--
Y.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Don-t-copy-bytea-text-in-convert_from-to-unless-conv.patch | application/octet-stream | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-11-24 15:14:24 | Re: Stack overflow issue |
| Previous Message | Drouvot, Bertrand | 2023-11-24 14:26:00 | Re: [PATCH] pg_convert improvement |