From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
---|---|
To: | Yurii Rashkovskii <yrashk(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] pg_convert improvement |
Date: | 2023-11-27 07:11:06 |
Message-ID: | 34e6eb59-d7a3-4f80-beab-30fe435cbf77@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 11/24/23 3:32 PM, Yurii Rashkovskii wrote:
> Hi Bertrand,
>
> On Fri, Nov 24, 2023 at 6:26 AM Drouvot, Bertrand <bertranddrouvot(dot)pg(at)gmail(dot)com <mailto:bertranddrouvot(dot)pg(at)gmail(dot)com>> wrote:
>
>
> The patch is pretty straightforward, I just have one remark:
>
> + /* if no actual conversion happened, return the original string */
> + /* (we are checking pointers to strings instead of encodings because
> + `pg_do_encoding_conversion` above covers more cases than just
> + encoding equality) */
>
> I think this could be done in one single comment and follow the preferred style
> for multi-line comment, see [1].
>
>
> Thank you for your feedback. I've attached a revised patch.
Did some minor changes in the attached:
- Started the multi-line comment with an upper case and finished
it with a "." and re-worded a bit.
- Ran pgindent
What do you think about the attached?
Also, might be good to create a CF entry [1] so that the patch proposal does not get lost
and gets visibility.
[1]: https://commitfest.postgresql.org/46/
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Don-t-copy-bytea-text-in-convert_from-to-unless-c.patch | text/plain | 1.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Guo | 2023-11-27 07:37:20 | Re: brininsert optimization opportunity |
Previous Message | Peter Eisentraut | 2023-11-27 07:08:08 | Re: Catalog domain not-null constraints |