Re: PATCH: save and restore the settings of the search objects dialog

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
Cc: "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: save and restore the settings of the search objects dialog
Date: 2014-07-09 10:40:25
Message-ID: CA+OCxozpJxL05E0u9hF6ZUq1A+kuhBkVHOKScY6fJ0B4F321UQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - patch applied.

On Tue, Jul 8, 2014 at 7:28 PM, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru> wrote:
> Hello J.F.
> Honestly, I don't sure that SaveSettings() must be called every time you
> push the Find button.
> What about the destructor method? (see the attached file)
>
> 08.07.2014 21:16, J.F. Oster пишет:
>
>> Hello,
>>
>> On Sun, Jun 22, 2014 at 11:29 AM, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
>> wrote:
>>>
>>> Hello.
>>> I think it'll be useful to save the settings of search objects dialog. So
>>> I
>>> decided to add this feature.
>>> Please see the attached patch.
>>> Thank you.
>>
>> Reporting my user experience :)
>> SaveSettings() is called on Cancel button press (and Esc key press).
>> If I close the dialog with Alt-F4 or a [x] button, settings won't get
>> saved. Same situation was in dlgFindReplace.
>> Also what if call SaveSettings() in OnSearch()?
>>
> --
> Dmitriy Olshevskiy
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2014-07-09 11:16:46 pgAdmin III commit: This patch adds search capabilities for:
Previous Message Dave Page 2014-07-09 10:40:16 pgAdmin III commit: Save search settings whenever the dialogue is close