Re: PATCH: save and restore the settings of the search objects dialog

From: Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
To: "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: PATCH: save and restore the settings of the search objects dialog
Date: 2014-07-08 18:28:39
Message-ID: 53BC3857.6010506@bk.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello J.F.
Honestly, I don't sure that SaveSettings() must be called every time you
push the Find button.
What about the destructor method? (see the attached file)

08.07.2014 21:16, J.F. Oster пишет:
> Hello,
>
> On Sun, Jun 22, 2014 at 11:29 AM, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru> wrote:
>> Hello.
>> I think it'll be useful to save the settings of search objects dialog. So I
>> decided to add this feature.
>> Please see the attached patch.
>> Thank you.
> Reporting my user experience :)
> SaveSettings() is called on Cancel button press (and Esc key press).
> If I close the dialog with Alt-F4 or a [x] button, settings won't get
> saved. Same situation was in dlgFindReplace.
> Also what if call SaveSettings() in OnSearch()?
>
--
Dmitriy Olshevskiy

Attachment Content-Type Size
t-10-moving-SaveSettings-to-destructor-method.patch text/plain 909 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2014-07-09 10:40:16 pgAdmin III commit: Save search settings whenever the dialogue is close
Previous Message J.F. Oster 2014-07-08 17:39:01 PATCH: More search in object's definitions