Re: Regarding feature #6841

Hi

On Wed, 17 Apr 2024 at 15:08, Anil Sahoo <anil(dot)sahoo(at)enterprisedb(dot)com>
wrote:

> Hi Hackers,
>
> This feature is about executing a query at the cursor position. And that
> query can be a one line or multiline. I have assigned a play icon button
> and F5 as the keyboard shortcut for the Execute Query feature, and for
> Execute Script, Playlist icon button and Alt+F5(Others),Option+F5(Mac) as
> keyboard shortcut.
>
> As now the query can run at cursor position, so for user convenience I am
> showing the current query just beside the Data Output toolbar. And on hover
> of the text, it will show the whole query as a tooltip. This query text
> will be available for both Execute Script and Execute Query.
>
> I have made the UI change for the feature #6841
> <https://github.com/pgadmin-org/pgadmin4/issues/6841>.
>
> Please provide your suggestions and feedback if these changes look okay to
> you.
>

How is this parsing the query to figure out the correct text to send to the
server? For example, I notice you have no semi-colons on many of the
queries in your test; is it breaking on newlines? What if there's a newline
(or multiple of them) in the query string? How does it cope with an
anonymous block containing multiple queries, or a pl/whatever function
definition that might contain queries within its text? Or a view definition?

--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com