Re: PATCH: To display column information properly in Properties Panel (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To display column information properly in Properties Panel (pgAdmin4)
Date: 2017-01-17 10:26:18
Message-ID: CA+OCxozVpaa5A_OA+xhS6H7oAK3N3Tw-7c5jYUeszGma6-VSnQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Fri, Jan 13, 2017 at 9:31 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to display columns in Properties panel for exclusion constraint
> node, and in addition to that I found similar issue with foreign key node.
>
> We will also remove placeholder from Select2 control if it's in Properties
> panel or disabled, it will be generic change in Select2 control in Backform
> as well as in Backgrid.
> RM#2065

A further improvement would be to omit the control entirely in the
properties list, so we just display the text. That's for another day
though :-).

Thanks - patch applied.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-01-17 10:45:05 pgAdmin 4 commit: Fix display of enum GUCs on users/databases etc. Fixe
Previous Message Dave Page 2017-01-17 10:25:30 pgAdmin 4 commit: Improve display of columns of exclusion contraints an