Re: [pgAdmin][RM5000] Logout the inactive session

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5000] Logout the inactive session
Date: 2020-01-15 07:57:20
Message-ID: CA+OCxozR_Kv3djDXr4fdeHU+RmPa2wdqVupTdge1t1jqHRwgaw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Jan 13, 2020 at 7:04 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch for the feature where inactive session will be
> logged out. Note that, here inactive session means no user activity of
> mouse move, click or keypress.
> I've introduced two config params:
> 1. USER_INACTIVITY_TIMEOUT - Interval in seconds for the timeout. Default
> is 0-Zero which means disabled.
> 2. OVERRIDE_USER_INACTIVITY_TIMEOUT - If set to true, tools like query
> tool or debugger will override USER_INACTIVITY_TIMEOUT and will not allow
> the application to timeout if a query is running for a long time.
>
> The patch also speeds up running jasmine test cases. With webpack 4, the
> default mode is changed to production instead of development unlike
> previous versions. Mode is set to development explicitly to improve the
> speed.
>

Per our discussion in the office, here's the suggested wording for the
config option descriptions:

+# USER_INACTIVITY_TIMEOUT is interval in Seconds. If the pgAdmin screen is
left
+# unattended for <USER_INACTIVITY_TIMEOUT> seconds then the user will
+# be logged out. When set to 0, the timeout will be disabled.
*# If pgAdmin doesn't detect any activity in the time specified (in
seconds), the user will
+# be forcibly logged out from pgAdmin. Set to zero to disable the timeout.
+USER_INACTIVITY_TIMEOUT = 0
+
+# OVERRIDE_USER_INACTIVITY_TIMEOUT when set to True will override
+# USER_INACTIVITY_TIMEOUT when long running queries in the Query Tool
+# or Debugger are running. When the queries complete, the inactivity timer
+# will restart in this case. If set to False, user inactivity may cause
transactions
+# or in-process debugging sessions to be aborted.
+OVERRIDE_USER_INACTIVITY_TIMEOUT = True

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2020-01-15 08:19:08 Re: RM5049 Patch
Previous Message Yogesh Mahajan 2020-01-15 07:36:33 RM5049 Patch