From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Atira Odhner <aodhner(at)pivotal(dot)io> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [patch] Show DDL for Greenplum Tables RM #2261 |
Date: | 2017-03-23 11:49:42 |
Message-ID: | CA+OCxozRXyX-2LPx571N2tmCVW_BL7C8e1M7OByHgAshzo8-Zg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patches applied.
Note that 0003 had one hunk rejected that I simply ignored as it was
for web/pgadmin/feature_tests/copy_selected_columns_feature_test.py
which doesn't currently exist in the community repo (the patch for
column selection was rejected as it didn't work consistently and
predictably).
On Wed, Mar 22, 2017 at 9:50 PM, Atira Odhner <aodhner(at)pivotal(dot)io> wrote:
> Hi Hackers,
>
> We have a fix for RM 2261:
>>
>> As a user of pgAdmin I want to be able to look at the DDL of an existing
>> table, copy and paste it into a SQL editor then modify it to create a new
>> table.
>>
>>
>>
>> GIVEN I have a table selected in the catalog browser
>> WHEN I select the SQL tab
>> THEN the Greenplum DDL will be visible like the Postgres DDL is already
>>
>>
>>
>> Currently the SQL tab displays an error
>
>
> This should also work for pre-9.1 postgres.
> We wrote tests for the sql changes that we made and created a few specific
> sql templates for versions prior to 9.1.
>
> We replaced the template selection feature test with the table DDL feature
> test because the table ddl feature test provides coverage for the template
> selection.
>
> Tira & Joao
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-03-23 11:59:36 | pgAdmin 4 commit: Re-organised the regression directory now we have mul |
Previous Message | Dave Page | 2017-03-23 11:47:25 | pgAdmin 4 commit: Replace the template selection feature test with one |