Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)
Date: 2019-05-21 12:02:29
Message-ID: CA+OCxoz+C3JKXMu2u7taYGSsSVAEQh20w2mDyxqLSKbbFq=21g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix the accessibility issue in query tool.
>
> The query tool can be completely restructured unlike previously where
> query tool used to stick at top and other tabs in the bottom.
> - I have added a new shortcut to switch between frames if in query tool
> the tab positions are changed. On switching the frames, the frame will
> blink to show it is focussed.
> - In the frame, you can switch tab same as previous. The tabs in SQL
> editor are cyclic now, which means if you execute shortcut to go right on
> the last tab then it will cycle to first tab.
> - I have also changed the default shortcut to switch between tabs from
> Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we have in
> browser tabs.
> - Similar changes done for debugger also.
>

Shouldn't there be documentation changes to go with this?

Otherwise, it seems to work :-)

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-05-21 12:12:09 Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)
Previous Message Dave Page 2019-05-21 11:14:39 pgAdmin 4 commit: Validate permissions on the session directory itself,