From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>, "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: wrong current schema in Search Objects dialog box |
Date: | 2014-06-16 07:58:28 |
Message-ID: | CA+OCxoyoFcL+Jbd=bxGMdhdsanaVNcUA1+hz1FiTg1ZhhpcUYw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi J.F.
Do you have a few minutes to look at this please?
Thanks.
On Sun, Jun 15, 2014 at 7:30 PM, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru> wrote:
> Hello.
> I applied this patch
> http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commitdiff;h=010e38cdd4991feaf2e757e803d330dc6c5bdba6
> and found that current schema is determined incorrectly when I select such
> objects as Constraints, Indexes, Rules or Triggers (parts of any Table).
> In this case combo-box contains item named "Current Schema (<table_name>)"
> instead of "Current Schema (<schema_name>)".
> Please, look at the module /pgadmin/dlg/dlgSearchObject.cpp (line 153) and
> especially at this place:
>
> if (obj->GetSchema())
> currentSchema = obj->GetSchema()->GetName();
> else if (obj->GetMetaType() == PGM_SCHEMA && !obj->IsCollection())
> currentSchema = obj->GetName();
> else
> currentSchema = wxEmptyString;
>
> Maybe here must be an additional check for an object's type (in first
> condition) or there is a bug in the definition of schemas for object tree?
> I have attached screenshots for better explaining the problem.
>
> --
> Dmitriy Olshevskiy
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | J.F. Oster | 2014-06-16 19:54:47 | Re: wrong current schema in Search Objects dialog box |
Previous Message | Dave Page | 2014-06-16 07:45:58 | Re: pgAdmin III commit: Modify the GNU build system so that it always rebui |