wrong current schema in Search Objects dialog box

From: Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: wrong current schema in Search Objects dialog box
Date: 2014-06-15 18:30:38
Message-ID: 539DE64E.2040902@bk.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello.
I applied this patch
http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commitdiff;h=010e38cdd4991feaf2e757e803d330dc6c5bdba6
and found that current schema is determined incorrectly when I select
such objects as Constraints, Indexes, Rules or Triggers (parts of any
Table).
In this case combo-box contains item named "Current Schema
(<table_name>)" instead of "Current Schema (<schema_name>)".
Please, look at the module /pgadmin/dlg/dlgSearchObject.cpp (line 153)
and especially at this place:

if (obj->GetSchema())
currentSchema = obj->GetSchema()->GetName();
else if (obj->GetMetaType() == PGM_SCHEMA && !obj->IsCollection())
currentSchema = obj->GetName();
else
currentSchema = wxEmptyString;

Maybe here must be an additional check for an object's type (in first
condition) or there is a bug in the definition of schemas for object tree?
I have attached screenshots for better explaining the problem.

--
Dmitriy Olshevskiy

Attachment Content-Type Size
image/png 14.1 KB
image/png 11.5 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Timon 2014-06-16 05:52:42 Re: pgAdmin III commit: Modify the GNU build system so that it always rebui
Previous Message rohtodeveloper 2014-06-13 07:53:46 help to review extension source(SQLServer->Postgresql)