Re: [pgAdmin4][RM#3154] Update modules to latest version

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version
Date: 2018-04-04 09:47:49
Message-ID: CA+OCxoynafNaOfb--rQmZFfrewRTuDZTYxMARN8p-RFOvKksCg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tue, Apr 3, 2018 at 4:49 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> ​Hi Dave,
>
> Reverted back jQuery version to 1.x because of SlickGrid dependancy.
> Please find updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Please hold on my previous patch.
>>
>> We can't use latest jQuery version as SlickGrid has dependancy on older
>> version.
>> I'll send updated patch again.
>>
>> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find updated patches, there are two patches attached one is for
>>> the story and another is for changes required as per new modules.
>>>
>>>
>>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala <
>>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> PFA patch to update the modules to latest version.
>>>>>
>>>>>
>>>> - Why isn't jQuery updated to 3.3.1?
>>>>
>>> ​Done​
>>>
>>>
>>>> ​
>>>>
>>>>
>>>
>>>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2
>>>> and pycrypto etc?
>>>>
>>> ​Done​
>>>
>>>
>>>>
>>>>
>>>>
>>>>> We are not able to update some of the modules to latest version due to
>>>>> dependancy on other modules, For example
>>>>> - Python: Flask-Security has dependancy on flask-babelex which causes
>>>>> conflict with flask_babel
>>>>>
>>>>
>>>> Hmm, flask-babelex might be a better option anyway; in particular, it
>>>> avoids loading catalogs with every request which seems desirable given the
>>>> size of ours. On the other hand, it hasn't been updated so recently.
>>>>
>>> ​I have removed flask-babel and used flask_babelex instead.​
>>>
>>>
>>>>
>>>>
>>>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch & Bootstrap Datetime
>>>>> picker has dependancy on Bootstrap3.
>>>>>
>>>>
>>>> OK.
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-04-04 09:49:28 Re: [pgAdmin4][RM#3154] Update modules to latest version
Previous Message Dave Page 2018-04-04 09:47:25 pgAdmin 4 commit: Update Python and JS modules. Fixes #3154