Re: PATCH: To fix the issue in Debugger module (pgAdmin4)

Hi

It still seems buggy. I started debugging list_emp() from our sample
DB, and just hit Step Into a few times randomly. It got as far as the
pg_sleep call I added, then never returned so I couldn't proceed. See
attached screenshot.

On Thu, Oct 6, 2016 at 10:05 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> PFA updated patch with suggestion given.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Oct 5, 2016 at 7:29 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> OK, that's much better. I think I've figured out what's causing the
>> remaining execution error as well - we're not disabling the buttons
>> until we get a response from the server, so if you click too quickly,
>> you make multiple requests at once. I tested this by adding a "SELECT
>> pg_sleep(2);" to a loop in a function.
>>
>> If you can fix that as well, then I think we can call this issue fixed.
>>
>> Thanks!
>>
>> On Wed, Oct 5, 2016 at 1:09 PM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi Dave,
>> >
>> > PFA updated patch for the same.
>> > RM#1227
>> >
>> > Please review.
>> >
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Mon, Oct 3, 2016 at 6:05 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Tue, Sep 27, 2016 at 7:40 AM, Murtuza Zabuawala
>> >> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> >> > Hi Dave,
>> >> >
>> >> > PFA updated patch to fix mentioned issue as well as incremental msgs
>> >> > updates
>> >> > in Messages Tab.
>> >>
>> >> This doesn't seem to work well. In pgAdmin 4 I get the following:
>> >>
>> >> ====
>> >> SELECT 1
>> >> INFO: EMPNO ENAME
>> >>
>> >>
>> >> INFO: ----- -------
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7369 SMITH
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7499 ALLEN
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7521 WARD
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7566 JONES
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7654 MARTIN
>> >>
>> >>
>> >> SELECT 1
>> >> INFO: 7698 BLAKE
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7782 CLARK
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7788 SCOTT
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7839 KING
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7844 TURNER
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7876 ADAMS
>> >>
>> >>
>> >> SELECT 1
>> >> INFO: 7900 JAMES
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7902 FORD
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7934 MILLER
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> SELECT 1
>> >> SELECT 1
>> >> ====
>> >>
>> >> Whilst in pgAdmin III I get:
>> >>
>> >> ====
>> >> INFO: EMPNO ENAME
>> >> INFO: ----- -------
>> >> INFO: 7369 SMITH
>> >> INFO: 7499 ALLEN
>> >> INFO: 7521 WARD
>> >> INFO: 7566 JONES
>> >> INFO: 7654 MARTIN
>> >> INFO: 7698 BLAKE
>> >> INFO: 7782 CLARK
>> >> INFO: 7788 SCOTT
>> >> INFO: 7839 KING
>> >> INFO: 7844 TURNER
>> >> INFO: 7876 ADAMS
>> >> INFO: 7900 JAMES
>> >> INFO: 7902 FORD
>> >> INFO: 7934 MILLER
>> >> SELECT 1
>> >> ====
>> >>
>> >> Sidenote: pgAdmin III uses a fixed-width font for this output which
>> >> works far better than pgAdmin 4's variable width font.
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company