Re: [Patch][pgAdmin4]: RM1442 - Table column data is incomplete for columns having more character lengths

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [Patch][pgAdmin4]: RM1442 - Table column data is incomplete for columns having more character lengths
Date: 2016-08-19 09:54:50
Message-ID: CA+OCxoygfB-JAOKV2ybTu4aeykC7N7hFKD-8Fb-KUncyLDh_bQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Aug 18, 2016 at 5:26 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> On Aug 18, 2016 9:42 PM, "Dave Page" <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Thu, Aug 18, 2016 at 1:39 PM, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> > Hi
>> >
>> > Issue:
>> > The table column data is incomplete for columns having more character
>> > lengths.
>> >
>> > Solution:
>> > Extends Backgrid.Cell and add 'mouseover' event. On mouse over, check if
>> > cell content is larger than the cell width, then add tooltip to the
>> > column
>> > by setting cell content in the title attribute.
>> >
>> > Please find attached patch and review.
>>
>> This has been taken care of in Murtuza's patch to move to SlickGrid.
>> Please check with him to ensure you've got the best solution between
>> both your patches. I won't commit this.

> As far as I know, we are using SlickGrid in query tool only

Good point - patch applied, thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2016-08-19 09:55:36 [pgAdmin4][Patch]: Feature #1406 - Allow setting to use spaces instead of tab in query editor
Previous Message Dave Page 2016-08-19 09:54:16 pgAdmin 4 commit: Display full text from backgrid cells that overflow i