From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview |
Date: | 2018-09-24 18:45:00 |
Message-ID: | CA+OCxoyNPVL_o=sZs34m_WTQ0rD-Mriknb8xMw30bxQAXo6e2A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Mon, Sep 24, 2018 at 2:05 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached updated patch.
>
> Feature Details:
> - The current tree state as well as the previous will be stored in the
> sqlite database.
> - The time interval to store the tree state is configurable via
> preferences and the default is 30 secs.
> -1 can be used to stop the tree saving functionality,
> - Jasmine test cases are included.
>
> Thanks,
> Khushboo
>
This is looking good, however there are a couple of cases where I think
it's not quite working as I would expect:
1) As soon as the user opens pgAdmin, the tree state should be restored.
2) If a database or server is disconnected, I would expect it's state to be
stored. When it is explicitly re-connected by the user, the state should be
restored.
I think that covers the different cases I'm imagining.
Thanks, Dave.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-09-24 20:22:10 | pgAdmin 4 commit: Update supported Python versions to match reality. |
Previous Message | pgAdmin 4 Jenkins | 2018-09-24 18:23:31 | Build failed in Jenkins: pgadmin4-master-python33 #763 |