Re: Event Triggers are not listed in the browser view options on the Settings dialogue

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Dhiraj Chawla <dhiraj(dot)chawla(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Event Triggers are not listed in the browser view options on the Settings dialogue
Date: 2013-09-23 15:38:11
Message-ID: CA+OCxoyE5pV0+za4XWAw4H+45fvasZdqzi9_qf5eu4L4OoDjvw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Fri, Sep 20, 2013 at 1:13 PM, Dhiraj Chawla
<dhiraj(dot)chawla(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> The Event Triggers options is not listed in the browser view options on the
> Settings dialog of pgAdmin, which would allow a user the hide/show the Event
> Triggers collection node. Attached is the patch that fixes this issue.
>
> Let me know your view on the same.

Thanks, that works. However, I notice it's not in the right place. We
normally display the nodes alphabetically - so can you please move the
Event Triggers node in the treeview so it appears before Extensions
(which I believe would be correct)?

Then, the position in the list on frmOptions should be corrected to
match. We list items there in the order they'd be seen in the
treeview, running down and across the logical hierarchy - which I
think means both Extensions and Event Triggers are in the wrong place
- they should probably be between Casts and Languages (though, looking
more closely, I think all the Foreign Table stuff is in the wrong
place too, so feel free to fix that as well)!

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dhiraj Chawla 2013-09-24 09:39:00 Re: Event Triggers are not listed in the browser view options on the Settings dialogue
Previous Message Dave Page 2013-09-23 10:34:22 Re: PATCH: Failed to take care of the function with first argument as OUT and second as IN/INOUT parameter