From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM5751] Enable the runtime menu when the timeout occurs |
Date: | 2020-08-25 10:41:25 |
Message-ID: | CA+OCxoy3JNpDXyzRAKsCTJYmcQuMDSZ=3_Xre+cKkmiinAwrsw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Looks OK to me. Please commit and have Fahar do some more in-depth testing
and if he finds anything else we can incrementally fix that before the next
release.
Thanks!
On Mon, Aug 24, 2020 at 3:05 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Dave/Hackers
>
> Attached is the patch to fix the following issues:
>
> - Enable the 'Configure' and 'View log' menu option when the server
> taking longer than usual time to start.
> - When an error occurs from the backend, the configure window opens
> and if the user has changed the setting of the port, it won't take any
> effect as we have retrieved the value of the port at the start of the
> runtime.
> - Added logic to identify the specified fixed port is already in use.
> Throw the error before starting the pgAdmin server.
>
> Please review and let me know any comments.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
From | Date | Subject | |
---|---|---|---|
Next Message | Nikhil Mohite | 2020-08-25 11:48:52 | Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website |
Previous Message | Aditya Toshniwal | 2020-08-25 10:38:33 | Re: [pgAdmin][SonarQube] Cognitive complexity |