Re: Patch for Synonym/Packages dialog documentation

From: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
To: Susan Douglas <susan(dot)douglas(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: Patch for Synonym/Packages dialog documentation
Date: 2016-10-26 10:25:18
Message-ID: CA+OCxoxuL4p4UejSR3QafK+=6ZcRG_9i0Z9tC3xie2P0qdQr2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Tue, Oct 25, 2016 at 5:18 PM, Susan Douglas
<susan(dot)douglas(at)enterprisedb(dot)com> wrote:
> Hi All,
>
> I've attached a patch that updates the documentation for the Synonym and Packages dialog - Murtuza has reviewed the Synonyms documentation, but I've not received feedback yet about the Packages documentation. If you could review it, and check it in, I'd appreciate it.
>
> If this should instead be added to the PEM repository, let me know, and I'll check it in - Thanks!

Not sure how you created this, but if I try to apply it with git apply I get:

piranha:pgadmin4 dpage$ git apply ~/Downloads/docpatch1025.patch
fatal: git diff header lacks filename information when removing 1
leading pathname component (line 3)

If I use patch, it patches sysnonym_dialog.rst, but none of the new
files are created:

piranha:pgadmin4 dpage$ patch -p1 < ~/Downloads/docpatch1025.patch
(Stripping trailing CRs from patch.)
patching file docs/en_US/synonym_dialog.rst
piranha:pgadmin4 dpage$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)

modified: docs/en_US/synonym_dialog.rst

no changes added to commit (use "git add" and/or "git commit -a")
piranha:pgadmin4 dpage$ git add -i
staged unstaged path
1: unchanged +15/-17 docs/en_US/synonym_dialog.rst

*** Commands ***
1: status 2: update 3: revert 4: add untracked
5: patch 6: diff 7: quit 8: help
What now> a
No untracked files.

--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-10-26 11:40:21 pgAdmin 4 commit: Improve the README to include comprehensive informati
Previous Message Dave Page 2016-10-26 09:30:54 pgAdmin 4 commit: Fix typo in 32bit-only code