Re: pgAgent: C++ Port - Patch Review

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Linreg <linreg(at)gmx(dot)net>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAgent: C++ Port - Patch Review
Date: 2013-09-11 13:02:05
Message-ID: CA+OCxoxkczHX+_sq0R2=JykFAK6uBOim6KYpVr59Hp1s0wCRiQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

Can you send a single patch please? "git diff > patch.diff" should do that.

Thanks.

On Wed, Sep 11, 2013 at 1:54 PM, Linreg <linreg(at)gmx(dot)net> wrote:
> Hello Dave,
>
>
>
> here are my first patches. i hope the format is correct.
>
>
>
> a liitle summary of my changes:
>
> -------------------------------
>
> + linux code is tested from me
>
> + windows code is edited, but not tested
>
>
>
> + wx-lib removed
>
> + c++ classes used
>
> + no mutex needed, database connection is rewritten, less code, simpler
> codeflow
>
> + cmake files are not adopted, i dont know how. i use qmake (sorry for that)
>
> + connectstring parsing rewritten
>
> + LogMessage has a timestamp column and is in csv like structure
>
> + pure c++ trim and replace function
>
> + ip validation: ipv6 testing is to simple in the moment
>
> + ip validation: unix domain socket alias filepath for host-values are
> accepted
>
>
>
> Question:
>
> can anyone give me a checklist for the window side?
>
> Or has anyone a visualstudio project file?
>
>
>
> Thomas Steffen
>
> ---------------------------------------------------------
>
> - Software Developer and engineer for electric technology
>
> - C/C++, Perl, VBA and many more
>
> ---------------------------------------------------------

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Linreg 2013-09-11 13:14:34 Re: pgAgent: C++ Port - Patch Review
Previous Message Linreg 2013-09-11 12:54:43 pgAgent: C++ Port - Patch Review