From: | Linreg <linreg(at)gmx(dot)net> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | pgAgent: C++ Port - Patch Review |
Date: | 2013-09-11 12:54:43 |
Message-ID: | 2098194.gxCLtb6LbE@wolfclan.ang.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hello Dave,
here are my first patches. i hope the format is correct.
a liitle summary of my changes:
-------------------------------
+ linux code is tested from me
+ windows code is edited, but not tested
+ wx-lib removed
+ c++ classes used
+ no mutex needed, database connection is rewritten, less code, simpler codeflow
+ cmake files are not adopted, i dont know how. i use qmake (sorry for that)
+ connectstring parsing rewritten
+ LogMessage has a timestamp column and is in csv like structure
+ pure c++ trim and replace function
+ ip validation: ipv6 testing is to simple in the moment
+ ip validation: unix domain socket alias filepath for host-values are accepted
Question:
can anyone give me a checklist for the window side?
Or has anyone a visualstudio project file?
Thomas Steffen
---------------------------------------------------------
- Software Developer and engineer for electric technology
- C/C++, Perl, VBA and many more
---------------------------------------------------------
Attachment | Content-Type | Size |
---|---|---|
connection.cpp.patch | text/x-patch | 20.0 KB |
job.cpp.patch | text/x-patch | 19.0 KB |
unix.cpp.patch | text/x-patch | 6.1 KB |
misc.cpp.patch | text/x-patch | 3.1 KB |
pgAgent.cpp.patch | text/x-patch | 14.9 KB |
win32.cpp.patch | text/x-patch | 9.5 KB |
connection.h.patch | text/x-patch | 5.7 KB |
job.h.patch | text/x-patch | 1.3 KB |
pgAgent.h.patch | text/x-patch | 2.1 KB |
misc.h.patch | text/x-patch | 583 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2013-09-11 13:02:05 | Re: pgAgent: C++ Port - Patch Review |
Previous Message | Dave Page | 2013-09-11 12:48:14 | pgAdmin III commit: Bump version for devel. |