From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch for RM1911 Direct file navigation [pgAdmin4] [Feature] |
Date: | 2016-12-19 11:46:00 |
Message-ID: | CA+OCxoxi2AR+=Ext1qDhNDatBcib72ZghbQyTdY7T651MFmXkA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Fri, Dec 16, 2016 at 6:46 PM, Harshal Dhumal
<harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Please find updated patch below for direct file navigation.
> I have covered all of above mentioned case.
Still not there I'm afraid:
- On Mac, if I type \Users\dpage, it changes it to /\Users\dpage and
then tells me it doesn't exist. Per the RM, either forward or back
slashes should be acceptable ("The path should accept either / or \ as
separators. Upon successful navigation to the path (after pressing
Return), the slashes should be replaced with the platform standard if
needed.")
- Unicode handling seems to be completely broken - see the attached screenshot.
I haven't tested on Windows yet, and only in Desktop mode on Mac.
Please test on Windows and Mac or Linux with both Python 2 and 3, in
both Server and Desktop modes to ensure that the behaviour meets the
requirements of the ticket with Unicode and non-Unicode paths and
files before resubmitting.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
Screen Shot 2016-12-19 at 11.38.44.png | image/png | 75.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-12-19 11:52:19 | Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin |
Previous Message | Dave Page | 2016-12-19 11:36:00 | Re: [pgAdmin4][Patch]: RM 1780: Rendering glitches in the query editor line number column when editing many lines |