Re: Patch for Race Condition.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Dinesh Kumar <dinesh(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for Race Condition.
Date: 2013-09-27 14:52:47
Message-ID: CA+OCxoxfsZiQ-X2Fd4Pmmx2+JeE=orbGoVVSkL20fOLPxH_hJw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - applied with minor changes to the comments and mutex name.

On Fri, Sep 27, 2013 at 8:51 AM, Dinesh Kumar <dinesh(dot)kumar(at)enterprisedb(dot)com
> wrote:

> Hi Dave,
>
> Sorry, it's my bad. The patch is build on another branch.
>
> Please find the attached patch which has been built on the pgAdmin master
> branch.
>
> Thanks in advance.
>
>
> Dinesh
>
> --
> *Dinesh Kumar*
> Software Engineer
>
> Ph: +918087463317
> Skype ID: dinesh.kumar432
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community> and
> more <http://www.enterprisedb.com/resources-community>
>
>
> On Thu, Sep 26, 2013 at 7:54 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>>
>> On Tue, Sep 24, 2013 at 12:37 PM, Dinesh Kumar <
>> dinesh(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave/Team,
>>>
>>> While working on one of the assigned task, i have been noticed the race
>>> condition on object "currentObject", which is concurrently updating
>>> by "onSelRightClick" and "execSelChange" methods. Due to this, sometimes, i
>>> am getting "n" Node context menu on "m" node.
>>>
>>> Ex:- When i right click on "server node", it is showing the "database
>>> node" popup menu options.
>>>
>>> I have been attaching the patch along with this request, and will be
>>> awaiting for your inputs.
>>>
>>
>> This doesn't apply - can you check the patch is correct please?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dinesh Kumar 2013-09-27 14:58:40 Re: Patch for Race Condition.
Previous Message Dave Page 2013-09-27 14:51:50 pgAdmin III commit: Prevent a race condition when setting currentObject